Bulk insert of failed receipts #326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusinacio
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Hello, first of all thanks for the contribution! From my point of view, this all makes sense and it should work properly.
One key point is that this approach misses sqlx greatest feature which is compile time checks. This is really important in case someone changes the code in the future so we know that it compiles to a valid sql.
Could you rewrite that using sqlx macros for compile-time checks?
|
You can find an example of how to do that using this as an example. indexer-rs/common/src/tap/receipt_store.rs Lines 41 to 63 in 5edf6cf |
|
Thanks for the review, I'll try using macros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
Sorry for the delay, I have tested the code[query creation part] by creating a similar table but not in the entire project, if possible please test it on your environment.